Skip to content

Fix build on powerpc*#985

Open
pkubaj wants to merge 2 commits into
RedisAI:mainfrom
pkubaj:patch-1
Open

Fix build on powerpc*#985
pkubaj wants to merge 2 commits into
RedisAI:mainfrom
pkubaj:patch-1

Conversation

@pkubaj

@pkubaj pkubaj commented Jul 3, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown

Two simple patches to fix powerpc* builds.

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Note

Low Risk
Small, build-target-specific wiring with no API or behavior change on x86_64/AArch64; PPC continues to use scalar distance paths guarded by existing arch macros.

Overview
Fixes powerpc* compilation and runtime CPU feature detection in VecSim by treating PPC like the existing x86_64 and AArch64 paths.

space_includes.h now includes cpuinfo_ppc.h when CPU_FEATURES_ARCH_PPC is defined. getCpuOptimizationFeatures in spaces.h selects cpu_features::PPCFeatures and GetPPCInfo on PPC instead of falling through to the x86 types and GetX86Info.

Reviewed by Cursor Bugbot for commit f033912. Bugbot is set up for automated code reviews on this repo. Configure here.

pkubaj added 2 commits July 3, 2026 11:37
@pkubaj
space_includes.h: add powerpc* support
15ccd6f 
Tested on FreeBSD/powerpc64le.
@pkubaj
spaces.h: fix build on powerpc*
f033912 
Tested on FreeBSD/powerpc64le.
@jit-ci

jit-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@CLAassistant

CLAassistant commented Jul 3, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@alonre24

alonre24 commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

@pkubaj Thank you for the contribution. First, please sign the CLA. Second, did you confirm that this addition would enable SIMD optimizations on PPC?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pkubaj @CLAassistant @alonre24